Skip to content

chore(experimental-utils): remove commented out RuleListeners #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2021
Merged

chore(experimental-utils): remove commented out RuleListeners #3667

merged 1 commit into from
Aug 1, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jul 31, 2021 •
edited
Loading

These were left over from #3560

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 1, 2021 •
edited
Loading

Codecov Report

Merging #3667 (e2da854) into master (ca7c549) will decrease coverage by 0.99%.
The diff coverage is n/a.

❗ Current head e2da854 differs from pull request most recent head 58764fd. Consider uploading reports for the commit 58764fd to get more accurate results

@@            Coverage Diff             @@
##           master    #3667      +/-   ##
==========================================
- Coverage   93.57%   92.58%   -1.00%     
==========================================
  Files         147      188      +41     
  Lines        7862     8478     +616     
  Branches     2489     2606     +117     
==========================================
+ Hits         7357     7849     +492     
- Misses        161      262     +101     
- Partials      344      367      +23
Flag Coverage Δ
unittest 92.58% <ø> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts 100.00% <0.00%> (ø)
packages/experimental-utils/src/json-schema.ts 100.00% <0.00%> (ø)
...kages/experimental-utils/src/eslint-utils/index.ts 100.00% <0.00%> (ø)
...perimental-utils/src/ts-eslint-scope/Definition.ts 100.00% <0.00%> (ø)
...ages/experimental-utils/src/ts-eslint/CLIEngine.ts 100.00% <0.00%> (ø)
.../experimental-utils/src/ts-eslint-scope/analyze.ts 100.00% <0.00%> (ø)
...s/experimental-utils/src/eslint-utils/deepMerge.ts 89.47% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 81.75% <0.00%> (ø)
...ackages/experimental-utils/src/ts-eslint/Linter.ts 100.00% <0.00%> (ø)
...experimental-utils/src/ts-eslint-scope/Variable.ts 100.00% <0.00%> (ø)
... and 31 more

@nx-cloud
Copy link

nx-cloud bot commented Aug 1, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 58764fd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx prebuild @typescript-eslint/types
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the refactor PRs that refactor code only label Aug 1, 2021
bradzacher
bradzacher approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 0bb878b into typescript-eslint:master Aug 1, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch August 1, 2021 01:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
refactor PRs that refactor code only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy