Skip to content

docs: alphabetize consistent-type-imports options for consistent type imports #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

docs: alphabetize consistent-type-imports options for consistent type imports #8553

merged 1 commit into from
Mar 5, 2024

Conversation

peanutenthusiast
Copy link
Contributor

PR Checklist

Overview

Alphabetized the options and default options in said file. Verified this when running local.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @peanutenthusiast!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ef8b89b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65dcdee841b1a80008529f02
😎 Deploy Preview https://deploy-preview-8553--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 26, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ef8b89b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (025e892) to head (ef8b89b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8553      +/-   ##
==========================================
- Coverage   87.84%   87.05%   -0.79%     
==========================================
  Files         397      251     -146     
  Lines       13844    12268    -1576     
  Branches     4073     3867     -206     
==========================================
- Hits        12161    10680    -1481     
+ Misses       1381     1316      -65     
+ Partials      302      272      -30
Flag Coverage Δ
unittest 87.05% <ø> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eslint-plugin/src/rules/consistent-type-imports.ts 95.25% <ø> (ø)

... and 146 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: alphabetize options for consistent type imports docs: alphabetize consistent-type-imports options for consistent type imports Mar 5, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Girl in pastel hat and clothing above a pastel sky and smiling sun saying "Perfect" and pointing to the captioned word "perfect"

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 49d79a6 into typescript-eslint:main Mar 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: order differs between Options and defaultOptions
2 participants
@peanutenthusiast @JoshuaKGoldberg
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy