fix(eslint-plugin): [prefer-regexp-exec] fix heuristic to check whether regex may contain global flag #8764
Conversation
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8764 +/- ##
==========================================
- Coverage 87.38% 87.33% -0.06%
==========================================
Files 254 254
Lines 12489 12467 -22
Branches 3919 3912 -7
==========================================
- Hits 10914 10888 -26
Misses 1304 1304
- Partials 271 275 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
Changes the heuristic to say "if we don't know what it is, it could have the global flag". Note that it could also be tricked into falsely flagging on factory functions that return a regexp, since the heuristic inspects the second argument without checking what function it's inspecting. That has been made more strict.
See examples in the playground