Skip to content

chore(deps): update actions/upload-artifact action to v4 #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 4, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/upload-artifact action major v3 -> v4

Release Notes

actions/upload-artifact (actions/upload-artifact)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Issue about dependencies of the package github-actions labels Apr 4, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @renovate[bot]!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1e1d628
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/662370d8d37c66000866809f
😎 Deploy Preview https://deploy-preview-8841--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Apr 4, 2024

@auvred
Copy link
Member

auvred commented Apr 20, 2024

The Codecov reports have not been uploaded since April 4 due to #8840.

Artifacts v4 is incompatible with Artifacts v3 - https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/:

Artifacts v4 is not cross-compatible with previous versions. For example, an artifact uploaded using v3 cannot be used with actions/download-artifact@v4.

Merging this PR should resolve the issue with Codecov reports

Currently the actions/upload-artifact@v4 fails in Run Unit Tests (ubuntu-latest, 20, eslint-plugin-internal) with error message:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

This is because actions/upload-artifact@v4 in Run Unit Tests (windows-latest, 20, eslint-plugin-internal) already uploaded an artifact with the same name - eslint-plugin-internal-coverage.

I think the solution is to upload artifacts only if matrix.os == 'ubuntu-latest'. This way we can avoid uploading artifacts for the same package multiple times.

Copy link
Contributor Author

renovate bot commented Apr 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@auvred
Copy link
Member

auvred commented Apr 20, 2024

@auvred auvred merged commit 5f38325 into main Apr 20, 2024
@auvred auvred deleted the renovate/actions-upload-artifact-4.x branch April 20, 2024 08:00
@auvred
Copy link
Member

auvred commented Apr 20, 2024

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package github-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy