docs: show importing configs in shared configs page #9562
Conversation
|
Thanks for the PR, @yaodada123! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is my first time to contribute to the project. I hope to get guidance and correction, so that I can make better contributions in the future |
There was a problem hiding this comment.
@yaodada123 Thanks for your first contribution to typescript-eslint!
The title issue was just a matter of adding a space in docs:show to be docs: show. Normally I'd suggest to look in the CI logs, since it gives an error message of why the title is invalid.... but in this case, the error message there was very vague and unhelpful 😆 so i went ahead and fixed it for you.
This PR will get merged when another team member has a chance to look at it and approve it.
Thanks again!
|
Oh, also - for future reference, please keep the magic "fixes #XXXX" text in the description template. That's how the PR autocloses the issue 🙂 You can read more how that works on the github docs. |
2ffa591
into
typescript-eslint:main
PR Checklist
Overview