fix(utils): correct types to align with @types/eslint v9 #9657
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| | /** @deprecated use `'writable'` */ 'writeable' | ||
| | /** @deprecated use `'readonly'` */ 'readable'; | ||
| export type GlobalVariableOptionBoolean = | ||
| | /** @deprecated use `'writable'` */ true | ||
| | /** @deprecated use `'readonly'` */ false; |
There was a problem hiding this comment.
There was a problem hiding this comment.
grumbles about the burden of years-long legacy support
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0546193. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
@bradzacher I think we do actually need to stay on pinned 2.3.0 for the v8 integration tests (that are failing)? Based on the changelog 2.4.0 moved to v9 types |
|
@JamesHenry Yeah it did but they hard-pinned it as a dependency. So realistically we could just remove it. I kept it there as a way to say "look this setup with local v8 types and a plugin on v9 typechecks fine". Sadly TS is very vague with that error message. I repro'd it locally via the test framework but not when |
|
It's a bug in their types: eslint-stylistic/eslint-stylistic#481 |
PR Checklist
Overview