Skip to content

docs: add note about typescript-eslint as peer dependency #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rainerhahnekamp
Copy link
Contributor

@rainerhahnekamp rainerhahnekamp commented Aug 19, 2024

PR Checklist

Overview

Explain, that there is not need to define the parser and therefore include typescript-eslint as peer dependency.

Explain, that there is not need to define the parser and therefore include `typescript-eslint` as peer dependency.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rainerhahnekamp!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5d82132
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66e435495ae4f90008caac28
😎 Deploy Preview https://deploy-preview-9820--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Aug 19, 2024

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (b413ec4) to head (5d82132).
Report is 158 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9820      +/-   ##
==========================================
+ Coverage   88.06%   88.69%   +0.62%     
==========================================
  Files         402      425      +23     
  Lines       13687    14810    +1123     
  Branches     3980     4308     +328     
==========================================
+ Hits        12054    13136    +1082     
- Misses       1324     1530     +206     
+ Partials      309      144     -165     
Flag Coverage Δ
unittest 88.69% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 180 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm not so sure what would actually be useful in the docs 🤔

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Aug 28, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and make an executive decision saying this is sufficient. We really only need the @typescript-eslint/parser as a peerDependency; everything else not mentioned in the doc is userland config.

Thanks for sending this in @rainerhahnekamp!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2ee528c into typescript-eslint:main Sep 13, 2024
8 of 9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Mention typescript-eslint not being needed as a peer dependency for custom plugins
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy