-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: add note about typescript-eslint as peer dependency #9820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note about typescript-eslint as peer dependency #9820
Conversation
Explain, that there is not need to define the parser and therefore include `typescript-eslint` as peer dependency.
Thanks for the PR, @rainerhahnekamp! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9820 +/- ##
==========================================
+ Coverage 88.06% 88.69% +0.62%
==========================================
Files 402 425 +23
Lines 13687 14810 +1123
Branches 3980 4308 +328
==========================================
+ Hits 12054 13136 +1082
- Misses 1324 1530 +206
+ Partials 309 144 -165
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm not so sure what would actually be useful in the docs 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go ahead and make an executive decision saying this is sufficient. We really only need the @typescript-eslint/parser
as a peerDependency
; everything else not mentioned in the doc is userland config.
Thanks for sending this in @rainerhahnekamp!
PR Checklist
Overview
Explain, that there is not need to define the parser and therefore include
typescript-eslint
as peer dependency.