Skip to content

[Fix] fix "exports" for node 13.0-13.6 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

[Fix] fix "exports" for node 13.0-13.6 #41

merged 1 commit into from
Apr 19, 2023

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Feb 7, 2023

  • node 13.0-13.1 only supports the string form
  • node 13.2 - 13.6 in an object only supports "default"

This commit allows these node versions to work.

@ljharb
[Fix] fix "exports" for node 13.0-13.6
a27206f 
 - node 13.0-13.1 only supports the string form
 - node 13.2 - 13.6 in an object only supports "default"

This commit allows these node versions to work.
@ljharb
Copy link
Contributor Author

ljharb commented Feb 7, 2023

cc @goto-bus-stop :-)

goto-bus-stop
goto-bus-stop approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i dont have perms here though 😄

@ljharb
Copy link
Contributor Author

ljharb commented Feb 28, 2023

oh noes! cc @twada

@falsandtru
Copy link

ping @twada

RebeccaStevens
RebeccaStevens reviewed Mar 29, 2023
View reviewed changes
@RebeccaStevens
Copy link

From the support-policy

We support Node under maintenance. In other words, we stop supporting old Node version when their maintenance ends.

Thus I don't think this PR will be getting merged. Node 13 isn't in LTS and Node 14 is going to be leaving LTS in a month.
If you need this functionality, I'd recommend using a patch. See pnpm patch or yarn patch.

@ljharb
Copy link
Contributor Author

ljharb commented Mar 30, 2023

@RebeccaStevens Support policy is irrelevant; engines.node dictates support and semver says that whatever works must continue working.

Patching installed modules live is FAR worse than forking them, ftr.

@ljharb
Copy link
Contributor Author

ljharb commented Apr 19, 2023

ping @twada; this is continuing to cause failures in some of my projects' CI, and i'd love it to be fixed.

I'd be more than happy to help you maintain this package if you're short on time!

@twada
Copy link
Member

twada commented Apr 19, 2023 •
edited
Loading

@ljharb Thank you for pinging me! I've been sick and absent recently, but will be rebooting now!
Thank you everyone in this issue. I'll cut a release soon.

@ljharb
Copy link
Contributor Author

ljharb commented Apr 19, 2023

<3 thank you! glad you're feeling better :-)

@twada
Copy link
Member

twada commented Apr 19, 2023

Support policy is irrelevant; engines.node dictates support and semver says that whatever works must continue working.

This is reasonable. engines.node must be defined explicitly. I'll work on this in next major.

@twada twada merged commit 8e65ba6 into unassert-js:master Apr 19, 2023
@twada
Copy link
Member

twada commented Apr 19, 2023

unassert 2.0.1 is out. Thank you @ljharb !
https://github.com/unassert-js/unassert/blob/master/CHANGELOG.md#201-2023-04-19

@ljharb ljharb deleted the patch-1 branch April 19, 2023 06:36
ljharb added a commit to ljharb/unassert that referenced this pull request Apr 19, 2023
@ljharb
[Fix] fix "exports" for node 13.0-13.6 take 2
c137b9b 
Followup to unassert-js#41.
@ljharb ljharb mentioned this pull request Apr 19, 2023
Merged
@ljharb
Copy link
Contributor Author

ljharb commented Apr 19, 2023

@twada i filed #46 as a followup - my apologies that further tweaks are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RebeccaStevens RebeccaStevens RebeccaStevens left review comments

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljharb @falsandtru @RebeccaStevens @twada @goto-bus-stop
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy