-
-
Notifications
You must be signed in to change notification settings - Fork 52
[UTC-184-A76] UAX31=Excluded vs. ID _ Type=Limited _ Use #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The most important files are missing... IdentifierType.txt & IdentifierStatus.txt |
When I generated the data after editing |
They should basically show the same changes as in draft-restrictions.txt. Looking at unicodetools/data/security/dev/IdentifierType.txt now I still see
Running either IdentifierInfo or GenerateConfusables (which also calls the former) should do it... The end goal is |
The "generated data" I mentioned was the result of running GenerateConfusables...so maybe something is not quite working as expected there? I'll have a closer look here. |
cdcf00e
to
10efac2
Compare
@markusicu I've been tinkering and hacking around on the unicodetools code and data here without success getting it to generate the IdentifierType.txt values as we want. I think we are going to have to look at getting an updated CLDR linked up in order to do this correctly. I'm going to close out this PR and see about starting up a new one with updated CLDR data (might need your help getting that...I think (as you mentioned separately) that we need an updated CLDR release that we can reference. |
taking a look, don't delete your branch yet... |
I see it in the debugger. unicodetools/unicodetools/src/main/java/org/unicode/text/UCD/IdentifierInfo.java Lines 567 to 568 in d8a2d08
I will try to hack the ID Usage change into the code. @macchiati I would have expected the ScriptMetadata to be used for script defaults, with removals.txt changes layered on top of that. Why is it the other way around? |
@josh-hadley I debugged it and hacked it. See my question to Mark above about data precedence. FYI: IdentifierStatus.txt is still unchanged. Neither ID_Type=Limited_Use nor Exclusion lead to ID_Status=Allowed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you squash-n-merge with just the last commit message (or something like it) for the whole thing.
[184-C33] Consensus: Change the Identifier_Type values for Gunjala Gondi characters (sc=Gong) from Limited_Use to Excluded, to match the UAX31 classification of the script. For Unicode Version 17.0. See L2/25-183 item 6.4.
[184-A76] Action Item for Josh Hadley, PAG: Derive the Identifier_Type values for Gunjala Gondi characters from the UAX31 classification of the script as specified. For Unicode Version 17.0. See L2/25-183 item 6.4.