Implement detect restriction level #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd have the API take a RestrictionLevel and return bool instead |
|
OK. And where should we implement the |
Manishearth
approved these changes
Jan 2, 2020
src/mixed_script.rs
Outdated
| if !GeneralSecurityProfile::identifier_allowed(ch) { | ||
| return RestrictionLevel::Unrestricted; | ||
| } | ||
| if ch as u32 > 0x7F { |
src/mixed_script.rs
Outdated
| let ch_set = ch.into(); | ||
| set = set.intersect(ch_set); | ||
| if !ch_set.base.contains_script(Script::Latin) { | ||
| exclude_latin_set.intersect(ch_set); |
There was a problem hiding this comment.
intersect() does not mutate.
Perhaps we should have an intersection() and intersect_with() pair of methods on unicode-script
|
Yes, please add it to unicode-script. While you're at it can you split the public |
|
ok. I'll create a branch and PR when i return from work today. |
fd51b23 to
b80d8f1
Compare
|
I made the changes upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft implementation. I implemented the algorithm itself, however there's a
Recommendedscript concept which is defined in TR31. For now thisis_recommended()method is not defined.