Skip to content

!fix: shouldn't using component resolver to resolve directive #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2021
Merged

!fix: shouldn't using component resolver to resolve directive #188

merged 2 commits into from
Oct 26, 2021

Conversation

hannoeru
Copy link
Member

  • breaking change: change to new component resolver interface, and separate resolver based on its type.
  • dynamic import Babel, as peer dependencies.
  • change some anonymous function to named function

If I use the v-lazy directive it will resolve to la:zy in unplugin-icons's resolver which will cause an error,
so I think we should separate the resolver based on its type.

@haoziqaq haoziqaq merged commit bb6dbeb into main Oct 26, 2021
@hannoeru
Copy link
Member Author

@martinussuherman I think we should wait for @sxzz to review this PR then merge to the main branch...

@haoziqaq
Copy link
Collaborator

revert it now?

@martinussuherman
Copy link
Collaborator

Yes, @hannoeru, I do think so. I only gave my review as was assigned to me ...
@haoziqaq I don't know, maybe ask @sxzz or @antfu ...

@haoziqaq
Copy link
Collaborator

We could wait for @antfu and @sxzz to check if revert is needed.

@martinussuherman
Copy link
Collaborator

Looking at this situation, I think maybe review should be made mandatory instead of optional. What I mean is without review approval from all that was involved then the PR cannot be merged. At current setting, I was able to merge even without any review approval, which is not a good thing imo.

@haoziqaq
Copy link
Collaborator

I agree

@antfu
Copy link
Member

antfu commented Oct 27, 2021 •
edited
Loading

@hannoeru I think we should compact the original interface but default to the components mode (directives will need to be set mandatory).

Regarding the PR, please feel free to review (that would be great helpful), but only merge when it's non-controversial (typos, the parts authored by you etc.). For breaking changes like this, please give me sometime to review so we don't fail the community.

I think the interface it better and more future proofing. We just need to make the transition smoother. @hannoeru can you work on top of this in another PR so we don't need to revert it (but release after it's done).

Thanks! (Sorry I don't read closed issues and PRs so I didn't notice the discussion here)

This was referenced Oct 27, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinussuherman martinussuherman martinussuherman approved these changes

@antfu antfu Awaiting requested review from antfu antfu is a code owner

@haoziqaq haoziqaq Awaiting requested review from haoziqaq haoziqaq is a code owner

@nabaonan nabaonan Awaiting requested review from nabaonan nabaonan is a code owner

@rafaelytakei rafaelytakei Awaiting requested review from rafaelytakei rafaelytakei is a code owner

@sxzz sxzz Awaiting requested review from sxzz sxzz is a code owner

@YannicEl YannicEl Awaiting requested review from YannicEl YannicEl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannoeru @haoziqaq @martinussuherman @antfu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy