Skip to content

fix: vantResolver partial name #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2022
Merged

fix: vantResolver partial name #377

merged 2 commits into from
May 5, 2022

Conversation

miyukoarc
Copy link
Contributor

VantResolver would make a mistake in generating component name
just like
VantButton: typeof import('vant/es')['tButton']
"vant/es/t-button/style/index" this file does not exist
maybe that can help

if (name.startsWith('Vant')) {
    const partialName = name.slice(4);
    return {
        /*... */
    };
}

@miyukoarc miyukoarc requested a review from antfu as a code owner May 5, 2022 17:15
antfu
antfu reviewed May 5, 2022
View reviewed changes
@antfu antfu merged commit 3e48b82 into unplugin:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyukoarc @antfu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy