test: add nested package json case #40
Conversation
WalkthroughThis update introduces new configuration and package definition files for a nested package setup using Yarn. In the Changes
Sequence Diagram(s)sequenceDiagram
participant T as Test (resolve_nested_dir_with_package_json)
participant R as Resolver
participant FS as Filesystem
T->>R: Initialize Resolver with default options
loop For each test case
T->>R: Request resolution [path, request]
R->>FS: Look up nested package.json configuration
FS-->>R: Return resolved output path
R-->>T: Provide resolved path
T->>T: Assert equality with expected result
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
fixtures/misc/nested-package-json/yarn.lockis excluded by!**/yarn.lock,!**/*.lockpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
fixtures/misc/nested-package-json/.gitignore(1 hunks)fixtures/misc/nested-package-json/.yarnrc.yml(1 hunks)fixtures/misc/nested-package-json/package.json(1 hunks)fixtures/misc/nested-package-json/package/nested/package.json(1 hunks)fixtures/misc/nested-package-json/package/package.json(1 hunks)fixtures/pnp/package.json(1 hunks)justfile(1 hunks)pnpm-workspace.yaml(1 hunks)src/tests/resolve.rs(1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
src/tests/resolve.rs (5)
src/tests/resolution.rs (1)
test(6-18)src/tests/mod.rs (1)
fixture_root(31-33)src/tests/tsconfig_paths.rs (5)
resolver(344-368)default(316-340)expected(151-151)expected(176-176)expected(210-210)src/lib.rs (2)
new(150-157)default(143-145)src/options.rs (1)
default(461-487)
🪛 GitHub Actions: Code Coverage
src/tests/resolve.rs
[error] 134-134: Test failed: assertion left == right failed: normal entry '/home/runner/work/unrs-resolver/unrs-resolver/fixtures/misc/nested-package-json' @root/package left: Err(NotFound('@root/package')) right: Ok('/home/runner/work/unrs-resolver/unrs-resolver/fixtures/misc/nested-package-json/package/output/index.js')
🪛 GitHub Actions: CI
src/tests/resolve.rs
[error] 134-134: Test failed: assertion left == right failed: normal entry "D:\a\unrs-resolver\unrs-resolver\fixtures\misc/nested-package-json" @root/package left: Err(NotFound("@root/package")) right: Ok("D:\a\unrs-resolver\unrs-resolver\fixtures\misc/nested-package-json\package/output/index.js")
🔇 Additional comments (8)
fixtures/pnp/package.json (1)
3-3: Yarn Version Bump VerificationThe update changes the
packageManagerfield to"yarn@4.8.0". This bump ensures consistency with the nested package setup. Please verify that all related documentation and tooling support Yarn 4.8.0.pnpm-workspace.yaml (1)
6-7: New Ignored Built Dependency EntryThe addition of
ignoredBuiltDependencieswith- esbuildis clear and helps prevent unnecessary build processing of esbuild. Verify that excluding esbuild does not affect any dependent build flows.fixtures/misc/nested-package-json/.yarnrc.yml (1)
1-3: Yarn Configuration SetupThis new
.yarnrc.ymldisables telemetry and setsnodeLinkertonode-modules, which aligns with typical local development setups. These settings appear appropriate for a nested package environment.fixtures/misc/nested-package-json/package/nested/package.json (1)
1-4: Nested Package Entry Point DeclarationThe
package.jsonin the nested directory correctly specifies the"main"and"types"fields with relative paths. Please confirm that these paths ("../output/nested.js"and"../output/nested.d.ts") resolve correctly in your build and consumption workflows.fixtures/misc/nested-package-json/.gitignore (1)
1-6: Refined .gitignore for Yarn ArtifactsThe new
.gitignorefile properly excludes the general.yarndirectory while whitelisting essential subdirectories (patches,plugins,releases,sdks, andversions). This configuration effectively balances between ignoring non-essential data and retaining necessary files.fixtures/misc/nested-package-json/package.json (1)
1-7: LGTM: Basic package.json structure is correctThis package.json correctly defines the package name, package manager version, and has a dependency on a local package using the link protocol.
fixtures/misc/nested-package-json/package/package.json (1)
1-6: LGTM: Package configuration looks correctThis package.json correctly defines a scoped package with main entry point and TypeScript definition file paths.
justfile (1)
18-18: LGTM: Command added correctlyThe command to install Yarn dependencies in the nested package json directory is correctly added to the install process.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 93.38% 93.38%
=======================================
Files 13 13
Lines 2827 2827
=======================================
Hits 2640 2640
Misses 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
## 🤖 New release
* `oxc_resolver`: 8.0.0 -> 9.0.0 (⚠ API breaking changes)
* `oxc_napi_resolver`: 8.0.0
### ⚠ `oxc_resolver` breaking changes
```text
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---
Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/constructible_struct_adds_field.ron
Failed in:
field ResolveOptions.modules in /tmp/.tmpTBvVad/oxc-resolver/src/options.rs:114
--- failure trait_method_added: pub trait method added ---
Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/trait_method_added.ron
Failed in:
trait method oxc_resolver::CachedPath::module_directory in file /tmp/.tmpTBvVad/oxc-resolver/src/cache.rs:69
trait method oxc_resolver::CachedPath::cached_node_modules in file /tmp/.tmpTBvVad/oxc-resolver/src/cache.rs:76
```
<details><summary><i><b>Changelog</b></i></summary><p>
## `oxc_resolver`
<blockquote>
##
[9.0.0](oxc-project/oxc-resolver@oxc_resolver-v8.0.0...oxc_resolver-v9.0.0)
- 2025-05-09
### <!-- 1 -->Bug Fixes
- hash import does not need to load from node_modules
([#501](oxc-project/oxc-resolver#501))
### <!-- 7 -->Chore
- add `--tsconfig` to example
([#505](oxc-project/oxc-resolver#505))
- publish `oxc_napi_resolver`
([#496](oxc-project/oxc-resolver#496))
</blockquote>
## `oxc_napi_resolver`
<blockquote>
##
[8.0.0](https://github.com/oxc-project/oxc-resolver/releases/tag/oxc_napi_resolver-v8.0.0)
- 2025-05-09
### <!-- 0 -->Features
- *(napi)* add mimalloc
([#423](oxc-project/oxc-resolver#423))
- [**breaking**] Rust Edition 2024
([#402](oxc-project/oxc-resolver#402))
- expose `package_json_path`
([#376](oxc-project/oxc-resolver#376))
- *(napi)* expose module type info in ResolveResult
([#223](oxc-project/oxc-resolver#223))
- *(napi)* add tracing via `OXC_LOG:DEBUG`
([#202](oxc-project/oxc-resolver#202))
- *(napi)* add async API
([#191](oxc-project/oxc-resolver#191))
- add `imports_fields` option
([#138](oxc-project/oxc-resolver#138))
- add more builder functions for options
([#110](oxc-project/oxc-resolver#110))
- *(napi)* support wasi target
([#31](oxc-project/oxc-resolver#31))
- add file_dependencies and missing_dependencies API
([#50](oxc-project/oxc-resolver#50))
- *(napi)* expose cloneWithOptions and clearCache methods
([#40](oxc-project/oxc-resolver#40))
- *(napi)* update the doc and type for tsconfig references
([#24](oxc-project/oxc-resolver#24))
- *(napi)* add options
([#19](oxc-project/oxc-resolver#19))
- *(resolver)* add tracing-subscriber feature
([#904](https://github.com/oxc-project/oxc-resolver/pull/904))
- *(resolver)* tsconfig project references
([#862](https://github.com/oxc-project/oxc-resolver/pull/862))
- *(resolver)* add thiserror
([#847](https://github.com/oxc-project/oxc-resolver/pull/847))
- *(resolver)* implement nested alias field
([#795](https://github.com/oxc-project/oxc-resolver/pull/795))
- *(resolver)* implement tsconfig-paths
([#750](https://github.com/oxc-project/oxc-resolver/pull/750))
- *(resolver)* implement configurable `exports_fields` option
([#733](https://github.com/oxc-project/oxc-resolver/pull/733))
- *(resolver)* implement `main_fields`
- *(resolver)* implement resolveToContext
([#694](https://github.com/oxc-project/oxc-resolver/pull/694))
- *(resolver)* implement restrictions (path only)
([#693](https://github.com/oxc-project/oxc-resolver/pull/693))
- *(resolver)* implement fully specified
([#687](https://github.com/oxc-project/oxc-resolver/pull/687))
- *(resolver)* imports field
([#681](https://github.com/oxc-project/oxc-resolver/pull/681))
- *(resolver)* finish most of exports field
([#674](https://github.com/oxc-project/oxc-resolver/pull/674))
- *(resolver)* port the rest of the exports field tests
([#659](https://github.com/oxc-project/oxc-resolver/pull/659))
- *(resolver)* implement symlinks
([#582](oxc-project/oxc-resolver#582))
- *(resolver)* complete query and fragment parsing
([#579](oxc-project/oxc-resolver#579))
- *(resolver)* add preferRelative and preferAbsolute
([#577](oxc-project/oxc-resolver#577))
- *(resolver)* implement roots
([#576](oxc-project/oxc-resolver#576))
- *(resolver)* implement fallback
([#572](oxc-project/oxc-resolver#572))
- *(resolver)* implement enforceExtension
([#566](oxc-project/oxc-resolver#566))
- *(resolver)* implement descriptionFiles option
([#565](oxc-project/oxc-resolver#565))
- *(resolver)* implement the basics of path alias
([#564](oxc-project/oxc-resolver#564))
- *(resolver)* accept different file system implementations
([#562](oxc-project/oxc-resolver#562))
- *(resolver)* implement browser field
([#561](oxc-project/oxc-resolver#561))
- *(resolver)* implement scoped packages
([#558](oxc-project/oxc-resolver#558))
- *(resolver)* port incorrect description file test
([#557](oxc-project/oxc-resolver#557))
- *(resolver)* implement extension_alias
([#556](oxc-project/oxc-resolver#556))
- *(resolver)* port resolve tests
([#555](oxc-project/oxc-resolver#555))
- *(resolver)* resolve extensions
([#549](oxc-project/oxc-resolver#549))
- *(resolver)* add resolver test fixtures
([#542](oxc-project/oxc-resolver#542))
### <!-- 1 -->Bug Fixes
- hash import does not need to load from node_modules
([#501](oxc-project/oxc-resolver#501))
- *(napi)* `new ResolverFactory()` options should be optional
([#256](oxc-project/oxc-resolver#256))
- *(napi)* update buggy NAPI-RS versions
([#225](oxc-project/oxc-resolver#225))
- canonicalize is not supported on wasi target
([#124](oxc-project/oxc-resolver#124))
- resolve "browser" field when "exports" is present
([#59](oxc-project/oxc-resolver#59))
### <!-- 4 -->Refactor
- [**breaking**] remove `description_files` option
([#488](oxc-project/oxc-resolver#488))
- [**breaking**] remove `modules` options
([#484](oxc-project/oxc-resolver#484))
- vitest ([#380](oxc-project/oxc-resolver#380))
- apply latest `cargo +nightly fmt`
([#281](oxc-project/oxc-resolver#281))
- selectively parse package_json fields instead of parsing everything
([#103](oxc-project/oxc-resolver#103))
- *(resolver)* clean up some code and tests
- *(resolver)* change internal funcs to non-pub by moving to unit tests
([#682](https://github.com/oxc-project/oxc-resolver/pull/682))
### <!-- 7 -->Chore
- publish `oxc_napi_resolver`
([#496](oxc-project/oxc-resolver#496))
- *(napi)* make mimalloc optional to build
([#495](oxc-project/oxc-resolver#495))
- *(README)* add wasm usage example
- *(README)* crates.io badge use recent downloads
- *(napi)* auto download wasm binding on webcontainer
([#471](oxc-project/oxc-resolver#471))
- use root package.json for napi build
([#469](oxc-project/oxc-resolver#469))
- *(deps)* update github-actions
([#444](oxc-project/oxc-resolver#444))
- *(deps)* lock file maintenance npm packages
([#436](oxc-project/oxc-resolver#436))
- bump napi
([#404](oxc-project/oxc-resolver#404))
- *(deps)* lock file maintenance npm packages
([#391](oxc-project/oxc-resolver#391))
- *(deps)* lock file maintenance rust crates
([#390](oxc-project/oxc-resolver#390))
- *(README)* clarify Rust and node.js usages
- add dprint
([#326](oxc-project/oxc-resolver#326))
- *(deps)* update napi-rs to 3.0.0-alpha
- `cargo upgrade` && `pnpm upgrade`
- *(deps)* update napi-rs to 3.0.0-alpha
- update napi changes
- *(deps)* update rust crate napi-derive to 3.0.0-alpha
- *(deps)* update rust crate napi to 3.0.0-alpha
- *(deps)* update napi-rs to 2.16.8
- *(napi)* make napi binary smaller with minimal tracing features
([#213](oxc-project/oxc-resolver#213))
- *(napi)* remove tokio
([#212](oxc-project/oxc-resolver#212))
- document directory is an absolute path for `resolve(directory,
specifier)`
([#206](oxc-project/oxc-resolver#206))
- re-enable the wasi build
([#193](oxc-project/oxc-resolver#193))
- use pnpm workspace
([#182](oxc-project/oxc-resolver#182))
- *(deps)* update rust crates
([#176](oxc-project/oxc-resolver#176))
- *(napi)* update NAPI-RS cli version and binding template
([#111](oxc-project/oxc-resolver#111))
- update project github url
- *(deps)* update pnpm to v8.14.1
([#52](oxc-project/oxc-resolver#52))
- *(deps)* update pnpm to v8.14.0
([#48](oxc-project/oxc-resolver#48))
- *(deps)* update pnpm to v8.13.1
([#42](oxc-project/oxc-resolver#42))
- remove FIXME comments
- *(napi)* align `*Fields` user options with enhanced-resolve
([#35](oxc-project/oxc-resolver#35))
- *(deps)* update pnpm to v8.12.1
([#21](oxc-project/oxc-resolver#21))
- add some doc for napi TsconfigOptions
([#20](oxc-project/oxc-resolver#20))
- *(deps)* update pnpm to v8.12.0
([#18](oxc-project/oxc-resolver#18))
- *(README)* adding debugging command from Rspack
- *(deps)* update pnpm to v8.11.0
([#9](oxc-project/oxc-resolver#9))
- *(resolver)* remove tracing_subscriber
([#1362](https://github.com/oxc-project/oxc-resolver/pull/1362))
- *(resolver)* improve documentation
([#591](oxc-project/oxc-resolver#591))
### <!-- 8 -->CI
- check for napi .d.index changes
([#491](oxc-project/oxc-resolver#491))
- *(release-napi)* support `riscv64gc-unknown-linux-gnu` and
`s390x-unknown-linux-gnu`
([#451](oxc-project/oxc-resolver#451))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Summary by CodeRabbit
Chores
.gitignore,.yarnrc.yml, and multiplepackage.jsonfiles for nested packages.Tests