Skip to content

Fix TestBrokenPipe on macOS #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Conversation

zawan-ila
Copy link
Contributor

Fixes 2770

@sethmlarson
Copy link
Member

@zawan-ila This doesn't have an explanation for why this PR is correct, I don't think we should be silencing exceptions we don't understand. Do you know why this issue is occurring?

@zawan-ila
Copy link
Contributor Author

@sethmlarson The reason that this is occuring is essentially the same as the one that we "catch" EPROTOTYPE here for. Remembrances from the past here and here

What's happened since then is that Apple changed some of their code and some of the code paths that resulted in the EPROTOTYPE mentioned above now result in the setting of ECONNRESET. In particular, note the difference in the if block between the old version and the new one. In fact, I don't think we need the special "catch" for EPROTOTYPE anymore.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! LGTM

@sethmlarson sethmlarson added the Skip Changelog Pull requests that don't require a changelog entry label Dec 28, 2023
@sethmlarson sethmlarson merged commit c7b9adc into urllib3:main Dec 28, 2023
@pquentin
Copy link
Member

Since we closed #2770, can we bump CI to macos-12?

@sethmlarson
Copy link
Member

@pquentin I believe we can! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestBrokenPipe.test_ignore_broken_pipe_errors fails on macOS 12 (Monterey)
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy