Skip to content

fix(amazon bedrock): reasoning configuration support #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2025
Merged

fix(amazon bedrock): reasoning configuration support #7231

merged 4 commits into from
Jul 11, 2025

Conversation

dancer
Copy link
Collaborator

@dancer dancer commented Jul 11, 2025

background

Amazon Bedrock models support reasoning/thinking functionality through the reasoningConfig parameter

summary

  • fix reasoning config transformation from reasoningConfig to thinking in request body

verification

  • proper parameter transformation and filtering works in both generate and stream modes

tasks

  • fix prepareJsonResponse function scope for test compatibility
  • correct reasoning config parameter names in tests (thinking → reasoningConfig)
  • filter reasoningConfig from final request body

@dancer dancer changed the base branch from main to v4 July 11, 2025 14:35
@dancer dancer closed this Jul 11, 2025
@dancer dancer reopened this Jul 11, 2025
@dancer dancer marked this pull request as ready for review July 11, 2025 14:36
@lgrammel
Copy link
Collaborator

pls add a changeset

@dancer dancer changed the title fix amazon bedrock reasoning configuration support fix (amazon bedrock): reasoning configuration support Jul 11, 2025
@dancer dancer changed the title fix (amazon bedrock): reasoning configuration support fix(amazon bedrock): reasoning configuration support Jul 11, 2025
@dancer dancer requested a review from lgrammel July 11, 2025 15:37
@dancer dancer merged commit 7687af8 into v4 Jul 11, 2025
8 checks passed
@dancer dancer deleted the js/bedrock branch July 11, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrammel lgrammel lgrammel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancer @lgrammel
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy