Skip to content

update mini-css-plugin and remove experimentalUseImportModule #30617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2021
Merged

update mini-css-plugin and remove experimentalUseImportModule #30617

merged 4 commits into from
Nov 2, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 29, 2021 •
edited by styfle
Loading

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 29, 2021
@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra marked this pull request as ready for review October 29, 2021 12:36
@sokra sokra marked this pull request as draft October 29, 2021 12:37
@sokra sokra marked this pull request as ready for review October 29, 2021 12:37
@stefanprobst
Copy link
Contributor

related #30367

styfle
styfle previously approved these changes Nov 1, 2021
View reviewed changes
@styfle styfle mentioned this pull request Nov 1, 2021
Closed
3 tasks
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Nov 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js css/upgrade Change
buildDuration 19s 18.7s -277ms
buildDurationCached 4s 4s -23ms
nodeModulesSize 293 MB 293 MB -1.09 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js css/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.907 2.906 0
/ avg req/sec 859.9 860.24 +0.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.401 1.378 -0.02
/error-in-render avg req/sec 1784.12 1814.77 +30.65
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js css/upgrade Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js css/upgrade Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js css/upgrade Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js css/upgrade Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js css/upgrade Change
index.html gzip 521 B 521 B ✓
link.html gzip 533 B 533 B ✓
withRouter.html gzip 515 B 515 B ✓
Overall change 1.57 kB 1.57 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js css/upgrade Change
buildDuration 20.2s 20.1s -52ms
buildDurationCached 3.9s 4.1s ⚠️ +213ms
nodeModulesSize 293 MB 293 MB -1.09 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js css/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.968 2.895 -0.07
/ avg req/sec 842.38 863.57 +21.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.394 1.416 ⚠️ +0.02
/error-in-render avg req/sec 1792.8 1765.55 ⚠️ -27.25
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js css/upgrade Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js css/upgrade Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js css/upgrade Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js css/upgrade Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js css/upgrade Change
index.html gzip 521 B 521 B ✓
link.html gzip 534 B 534 B ✓
withRouter.html gzip 516 B 516 B ✓
Overall change 1.57 kB 1.57 kB ✓
Commit: eb1b125

@kodiakhq kodiakhq bot merged commit 3674ccb into canary Nov 2, 2021
@kodiakhq kodiakhq bot deleted the css/upgrade branch November 2, 2021 21:56
This was referenced Nov 5, 2021
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimentalUseImportModule should be disabled
4 participants
@sokra @ijjk @stefanprobst @styfle
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy