Skip to content

Added section about router methods returning a promise #31341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 19, 2021
Merged

Added section about router methods returning a promise #31341

merged 13 commits into from
Dec 19, 2021

Conversation

molebox
Copy link
Contributor

@molebox molebox commented Nov 12, 2021 •
edited
Loading

This PR adds a section on certain router methods returning a promise, and the error you will see if you have no-floating-promises enabled.

Bug

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

leerob
leerob reviewed Nov 12, 2021
View reviewed changes
@molebox molebox requested a review from leerob December 1, 2021 13:20
leerob
leerob reviewed Dec 1, 2021
View reviewed changes
molebox and others added 4 commits December 14, 2021 09:37
@molebox @leerob
Update docs/api-reference/next/router.md
9b12011 
Co-authored-by: Lee Robinson <me@leerob.io>
@molebox @leerob
Update docs/api-reference/next/router.md
a3f8314 
Co-authored-by: Lee Robinson <me@leerob.io>
@molebox @leerob
Update docs/api-reference/next/router.md
bfa7578 
Co-authored-by: Lee Robinson <me@leerob.io>
@molebox
Merge branch 'canary' into router.push-returns-promise
1d21939
@molebox molebox requested review from leerob and removed request for lfades December 14, 2021 08:38
styfle
styfle reviewed Dec 14, 2021
View reviewed changes
@molebox molebox requested a review from styfle December 15, 2021 15:29
styfle
styfle reviewed Dec 17, 2021
View reviewed changes
@kodiakhq kodiakhq bot merged commit f176683 into vercel:canary Dec 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@molebox @styfle @leerob @ijjk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy