Skip to content

Remove unused turbo env vars #32588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Remove unused turbo env vars #32588

merged 1 commit into from
Dec 17, 2021

Conversation

jaredpalmer
Copy link
Contributor

Remove unused environment variables from GitHub Actions.

We'll add these back once we enable remote caching

@ijjk
Copy link
Member

ijjk commented Dec 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
buildDuration 18s 18.2s ⚠️ +175ms
buildDurationCached 3.3s 3.4s ⚠️ +6ms
nodeModulesSize 348 MB 348 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.891 2.879 -0.01
/ avg req/sec 864.89 868.28 +3.39
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.34 1.309 -0.03
/error-in-render avg req/sec 1865.53 1909.79 +44.26
Client Bundles (main, webpack, commons)
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
buildDuration 19.6s 19.5s -118ms
buildDurationCached 3.3s 3.3s ⚠️ +1ms
nodeModulesSize 348 MB 348 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.89 2.906 ⚠️ +0.02
/ avg req/sec 865.04 860.41 ⚠️ -4.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.331 1.316 -0.01
/error-in-render avg req/sec 1877.94 1899.95 +22.01
Client Bundles (main, webpack, commons)
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.3 kB 74.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary jaredpalmer/next.js remove-remote-caching Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 6f4ac2c

@ijjk ijjk merged commit f4e4937 into vercel:canary Dec 17, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@padmaia padmaia padmaia approved these changes

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaredpalmer @ijjk @styfle @padmaia
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy