Skip to content

Simplify trace span id generation #32946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2022
Merged

Simplify trace span id generation #32946

merged 1 commit into from
Jan 2, 2022

Conversation

timneutkens
Copy link
Member

Uses a simple counter for span ids, previously these required to be randomly generated but I've changed the importer script to ensure it gets prepended 0s to make sure it gets to 16 characters which Jaeger requires.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 2, 2022
@ijjk
Copy link
Member

ijjk commented Jan 2, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
buildDuration 18.5s 18.4s -51ms
buildDurationCached 4s 4.1s ⚠️ +137ms
nodeModulesSize 348 MB 348 MB -245 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.914 3.925 ⚠️ +0.01
/ avg req/sec 638.77 636.92 ⚠️ -1.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.045 2.094 ⚠️ +0.05
/error-in-render avg req/sec 1222.44 1193.99 ⚠️ -28.45
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27 kB 27 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
buildDuration 20.5s 20.5s -40ms
buildDurationCached 4s 4.1s ⚠️ +13ms
nodeModulesSize 348 MB 348 MB -245 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.898 3.934 ⚠️ +0.04
/ avg req/sec 641.34 635.55 ⚠️ -5.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.024 2.069 ⚠️ +0.04
/error-in-render avg req/sec 1235.13 1208.56 ⚠️ -26.57
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/fast-span-id Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: b02b64d

@kodiakhq kodiakhq bot merged commit a5bfc1e into vercel:canary Jan 2, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy