[Fix] Remove unused opentelemetry-semantic-conventions-ai dependency #19313
Conversation
Signed-off-by: Conroy Cheers <conroy@corncheese.org>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Hello @conroy-cheers, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, gemini-code-assist here to provide a quick summary of this pull request. The primary goal of this PR, authored by @conroy-cheers, is to clean up the project's dependencies by removing the opentelemetry-semantic-conventions-ai package. According to the description, this dependency was made obsolete by a previous change (#12007) and is no longer used. The plan is that when the relevant OpenTelemetry API stabilizes, the necessary components will be imported from the standard opentelemetry-semantic-conventions package instead. This PR effectively removes the unused dependency from the project's requirements and documentation.
Highlights
- Dependency Removal: The core change is the removal of the
opentelemetry-semantic-conventions-aidependency, which is no longer needed after a previous refactor. - Requirements Cleanup: The dependency is removed from both the main
requirements/common.txtfile and the example installation instructions in the OpenTelemetry README.
Changelog
- examples/online_serving/opentelemetry/README.md
- Removed
opentelemetry-semantic-conventions-aifrom the list of required packages in the installation instructions (line 10).
- Removed
- requirements/common.txt
- Removed the
opentelemetry-semantic-conventions-aidependency from the main requirements file (line 50).
- Removed the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively removes the opentelemetry-semantic-conventions-ai dependency, which is a good maintenance step as it's reportedly no longer in use. The changes in requirements/common.txt and the example README are clear and directly address the goal. The local definitions of semantic convention constants in vllm/tracing.py support the claim that this specific AI-focused package is no longer needed.
Well done on keeping the project's dependencies lean!
Summary of Findings
- Dependency Removal: The pull request successfully removes the
opentelemetry-semantic-conventions-aidependency fromrequirements/common.txtand updates the installation instructions inexamples/online_serving/opentelemetry/README.md. This aligns with the PR's goal of removing an unused dependency. - Code Correctness: Based on the provided context and the local definitions of OpenTelemetry semantic attributes in
vllm/tracing.py, the removal of this dependency appears correct and should not cause issues.
Merge Readiness
The changes look good and address the stated purpose of removing an unused dependency. The PR appears ready for merging. As always, ensure that all CI checks and tests pass before merging. I am unable to approve the pull request myself; please have another team member review and approve.
Purpose
#12007 removed all uses of
opentelemetry-semantic-conventions-ai, but it is still present in the requirements.It should not be required again, as once the API is stabilized it will be imported from
opentelemetry-pythoninstead.Test Plan
Test Result