chore: format code & remove extra blank lines #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
requested changes
Oct 8, 2022
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1.0"> | ||
| <meta charset="utf-8" /> |
There was a problem hiding this comment.
<meta> is a void element, thus there should be no end tag.
https://html.spec.whatwg.org/multipage/semantics.html#the-meta-element
There was a problem hiding this comment.
OK, thanks for the documentation instructions. The end tag here is added after running pnpm format, maybe this is a problem with prettier? 🤔
There was a problem hiding this comment.
Yeah, tracked at prettier/prettier#5246
In that case, I'd like to add **/*.html to the project .prettierignore for now.
haoqunjiang
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.