refactor!: run cypress headlessly by default; add test:*:dev commands #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is not very useful unless we use `--strictPort` here, and keeping it makes it harder for us to customize the port number on command line.
for headed environment and testing against dev server. I think this better reflects the real-world use case. People don't usually need an app window to run the tests against the production bundle, but faster feedback loops with dev server are useful.
haoqunjiang
commented
Oct 20, 2022
| "test:e2e": "start-server-and-test preview http://localhost:4173/ 'cypress open --e2e'", | ||
| "test:e2e:ci": "start-server-and-test preview http://localhost:4173/ 'cypress run --e2e'" | ||
| "test:e2e": "start-server-and-test preview :4173 'cypress run --e2e'", | ||
| "test:e2e:dev": "start-server-and-test 'vite dev --port 4173' :4173 'cypress open --e2e'" |
There was a problem hiding this comment.
I chose to force the dev server to run on 4173 instead of 5173 as in the playwright PR #182 because start-server-and-test doesn't have an option like reuseExistingServer, therefore has a higher chance of port collisions during dev.
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for headed environment and testing against dev server.
I think this better reflects the real-world use case.
People don't usually need an app window to run the tests against
the production bundle, but faster feedback loops with dev server are
useful.
Inspired by @elevatebart 's comment on twitter: https://twitter.com/elevatebart/status/1582790882088009728