Skip to content

test(func-call-spacing): make tests more strict #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test(func-call-spacing): make tests more strict #2830

wants to merge 2 commits into from
+9 −11

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Jul 25, 2025

Continuation of #2793

This PR converts all error assertions for func-call-spacing to include both error message and full location checks.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7474b85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

FloEdelmann
FloEdelmann previously approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tests/lib/rules/func-call-spacing.js
@@ -61,10 +60,9 @@ tester.run('func-call-spacing', rule, {
`,
errors: [
{
message: semver.lt(ESLint.version, '7.0.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to see legacy code removed 🙂

@FloEdelmann FloEdelmann dismissed their stale review July 25, 2025 17:04

I missed that tests are failing

FloEdelmann
FloEdelmann requested changes Jul 25, 2025
View reviewed changes
tests/lib/rules/func-call-spacing.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing, could you have a look at those please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it only fails when eslint stylistic is missing.
Any idea why this might be the case?

If not, I can revert adding the column property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ST-DDT @FloEdelmann
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy