Add plugin in config, update README #1
Conversation
| @@ -9,7 +11,6 @@ ESLint plugin for libs in the vuejs organization. Note this is an internal plugi | |||
|
|
|||
| ```js | |||
| { | |||
| plugins: ["vue-libs"], | |||
There was a problem hiding this comment.
I'd say we should rather present two examples, like so:
{
plugins: ['vue-libs'],
rules: {
// set all rules that you're interested in
}
}
and
{
extends: ['plugin:vue-libs/recommended'],
rules: {
// override rules' settings if necessary
}
}
| @@ -1,5 +1,5 @@ | |||
| module.exports = { | |||
| plugins: ['html'], | |||
| plugins: ['html', 'vue-libs'], | |||
There was a problem hiding this comment.
we don't want to depend on ourselves 😛
There was a problem hiding this comment.
These are recommended settings so I think it's perfectly fine to keep it there. Especially because you already set 'vue-libs/jsx-uses-vars': 2 in this config.
Btw. it's also what other plugins do in theirs recommended configurations e.g.: https://github.com/yannickcr/eslint-plugin-react/blob/master/index.js
There was a problem hiding this comment.
Oh my bad! I didn't see it was the recommended sorry!
README.md
Outdated
| ESLint plugin for libs in the vuejs organization. Note this is an internal plugin/config for the development of Vue itself, not intended for Vue app development. | ||
| > ESLint plugin for libs in the vuejs organization. | ||
|
|
||
| ❗️ Note this is an internal plugin/config for the development of Vue itself, not intended for Vue app development. |
There was a problem hiding this comment.
I think github emoji code is human editable rather than emoji binary code. (e.g: :exclamation:)
This PR simplifies further configuration by adding
vue-libsplugin in recommended config.