Fix test about assigning to frozen object in chrome. #2165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting... it works on my Chrome with the same version. Are you using Windows? |
|
Sorry for forgetting notice that I am using Windows 7. Screenshot as follows. After looking into MDN, writting to properties of frozen object will throw TypeError in strict mode, and silently fails without strict mode. Here is a demo, my browser shows So maybe checking your test environment is in strict mode or not will helps?
|
yyx990803
added a commit
that referenced
this pull request
Jan 18, 2016
Fix test about assigning to frozen object in chrome.
|
Ah, ok. Thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assigning property to a frozen object, an error is occurred in my chrome 47.0.2526.106