Skip to content

fix(useWebWorker): prevent error event bubbling #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2023
Merged

fix(useWebWorker): prevent error event bubbling #3141

merged 4 commits into from
Aug 25, 2023

Conversation

Luvoy
Copy link
Contributor

@Luvoy Luvoy commented Jun 7, 2023 •
edited
Loading

The ErrorEvent is always bubbled to window, even if we use try-catch to wrap workerFn. I think it's better to prevent the bubble behavior.

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

The ErrorEvent is always bubbled to window. If we use 2 or 3 useWebWorkerFn in different vue components, one ErrorEvent from one Fn will cover all these components.

Additional context

🤖 Generated by Copilot at 531edeb

Prevent default error handling of web worker in useWebWorkerFn hook. This allows users to catch and handle errors from the worker function without losing the worker instance.

🤖 Generated by Copilot at 531edeb

  • Prevent default error handling of web worker and expose error event to user (link)

@Luvoy
Update index.ts
531edeb 
The ErrorEvent is always bubbled to window, even if we use try-catch to wrap workerFn. I think it's better to prevent the bubble behavior.
@antfu antfu changed the title Update index.ts fix(useWebWorker): prevent error event bubbling Jun 28, 2023
antfu
antfu reviewed Aug 25, 2023
View reviewed changes
@antfu antfu enabled auto-merge August 25, 2023 16:23
@antfu antfu added this pull request to the merge queue Aug 25, 2023
Merged via the queue into vueuse:main with commit 3420640 Aug 25, 2023
This was referenced Sep 28, 2023
Merged
Merged
@renovate renovate bot mentioned this pull request Nov 13, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luvoy @antfu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy