Skip to content

fix(useScroll): evade edge case when window or document is Proxy #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix(useScroll): evade edge case when window or document is Proxy #3280

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab6806a
fix(useScroll): evade edge case when window or document is Proxy
MinatoHikari Aug 1, 2023
da491fc
Merge branch 'main' into main
MinatoHikari Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(useScroll): evade edge case when window or document is Proxy
  • Loading branch information
@MinatoHikari
MinatoHikari committed Aug 1, 2023
commit ab6806a9c93ca98e00f034023ef54d12b0bc60ea
6 changes: 3 additions & 3 deletions packages/core/useScroll/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ export function useScroll(
return

const el = (
target === window
(target as Window).document
? (target as Window).document.documentElement
: target === window.document ? (target as Document).documentElement : target
: (target as Document).documentElement ?? target
) as HTMLElement

const { display, flexDirection } = getComputedStyle(el)
Expand Down Expand Up @@ -233,7 +233,7 @@ export function useScroll(
return

const eventTarget = (
e.target === window.document ? (e.target as Document).documentElement : e.target
(e.target as Document).documentElement ?? e.target
) as HTMLElement

setArrivedState(eventTarget)
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy