Skip to content

fix(useCssVar): avoid untarget style pollution #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(useCssVar): optimize target value tracking by changing targetHadV…
…alue to a primitive boolean
  • Loading branch information
ArthurDarkstone committed Jun 30, 2025
commit cb0228afdd450a477c4cbdfefcbf264ca8a974f9
6 changes: 3 additions & 3 deletions packages/core/useCssVar/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,19 @@ export function useCssVar(
const variable = shallowRef(initialValue)

// Track if target has ever had a truthy value
const targetHadValue = shallowRef(false)
let targetHadValue = false

const elRef = computed(() => {
const element = unrefElement(target)

if (element) {
targetHadValue.value = true
targetHadValue = true
return element
}

// If target never had a value, use documentElement as fallback
// If target had a value but now is undefined, don't use fallback
return targetHadValue.value ? null : window?.document?.documentElement
return targetHadValue ? null : window?.document?.documentElement
})

function updateCssVar() {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy