-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(useFocusTrap): expose updateContainerElements for dynamic contai… #4849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeikyLiu
wants to merge
9
commits into
vueuse:main
Choose a base branch
from
PeikyLiu:useFocusTrap/updateContainerElements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(useFocusTrap): expose updateContainerElements for dynamic contai… #4849
PeikyLiu
wants to merge
9
commits into
vueuse:main
from
PeikyLiu:useFocusTrap/updateContainerElements
+71
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyaliao
previously approved these changes
Jul 4, 2025
OrbisK
reviewed
Jul 6, 2025
…kyLiu/vueuse into useFocusTrap/updateContainerElements
ilyaliao
reviewed
Jul 20, 2025
Co-authored-by: IlyaL <ilyaliao324@gmail.com>
ilyaliao
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Feature: Expose updateContainerElements method in useFocusTrap
Description
This PR exposes the
updateContainerElements
method from the underlying focus-trap library, allowing users to dynamically update focus trap containers while the trap is active.Related Issues
resolve #4848
📋 Changes
updateContainerElements
method toUseFocusTrapReturn
interfaceContainerElements
type alias usingParameters<FocusTrap['updateContainerElements']>[0]
undefined
case when trap is not initialized🔧 Technical Details
Parameters
utility type to automatically inherit parameter types from focus-trap library📚 Example Usage
🔄 Breaking Changes
None - this is a purely additive change.