-
Notifications
You must be signed in to change notification settings - Fork 71
Enhanced QRG Input #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Enhanced QRG Input #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ad31df.
Closed
int2001
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works.
tested:
- LiveQSO with CAT
- LiveQSO without CAT
- PostQSO
- Contesting with CAT
- Contesting without CAT
- DXCluster / Spot-Click
Important:
since this one affects the core of logging, id appreciate another approve besides mine. Maybe i've overseen something
Checked again. Now SAT is working too |
AndreasK79
approved these changes
Nov 17, 2024
Nice addition. Tested and clicked around. Logged a few QSOs. Seems ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced QRG Input
Using always Hertz as QRG unit is not just annoying, but also not really user friendly. Therefore we should allow to use more user-friendly units to set/display the frequency. A first step was done in #544 and #784 but the QRG input itself was missing. This now changed. Base issue is #165
Usage
There are now several ways to enter a frequency. A user is free to choose which one is prefered.
Same QRG Unit
If the QRG unit is

kHz
and the user wants to usekHz
he can simply type in the frequency and hit enterChange QRG Unit
Change by input
If a user want to change the QRG quickly and wants to use a different QRG unit he can simply type that unit after the frequency (

mhz
orm
works, same for other units) . Wavelog will recognize that and change the unit accordingly.Change by click
If the user rather want to use the mouse to change the QRG unit he can simply click on the unit in the frequency input

Technical
The QRG units are already stored in the session data (server side). The new code now stores the QRG units additionally in the localStorage (browser side, only in QSO and Contesting view) to avoid slow ajax calls and make the whole logic faster. The localStorage gets cleared when reloading the page. If a user want to use a different QRG Unit then already set then he can change the unit per band in the 'Bands' menu (User -> Bands).
Progress
Note about SimpleFLE
SimpelFLE is based on FLE by DF3CB which always uses MHz. To stay close to the original FLE syntax we use MHz here aswell.