Skip to content

Enhanced QRG Input #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Nov 17, 2024
Merged

Enhanced QRG Input #1196

merged 21 commits into from
Nov 17, 2024

Conversation

HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented Nov 12, 2024

Enhanced QRG Input

Using always Hertz as QRG unit is not just annoying, but also not really user friendly. Therefore we should allow to use more user-friendly units to set/display the frequency. A first step was done in #544 and #784 but the QRG input itself was missing. This now changed. Base issue is #165

image

Usage

There are now several ways to enter a frequency. A user is free to choose which one is prefered.

Same QRG Unit

If the QRG unit is kHz and the user wants to use kHz he can simply type in the frequency and hit enter
ezgif-7-700f45041d

Change QRG Unit

Change by input

If a user want to change the QRG quickly and wants to use a different QRG unit he can simply type that unit after the frequency (mhz or m works, same for other units) . Wavelog will recognize that and change the unit accordingly.
ezgif-7-48dcc44282

Change by click

If the user rather want to use the mouse to change the QRG unit he can simply click on the unit in the frequency input
ezgif-7-144f6b4c57

Technical

The QRG units are already stored in the session data (server side). The new code now stores the QRG units additionally in the localStorage (browser side, only in QSO and Contesting view) to avoid slow ajax calls and make the whole logic faster. The localStorage gets cleared when reloading the page. If a user want to use a different QRG Unit then already set then he can change the unit per band in the 'Bands' menu (User -> Bands).

Progress

  • Show QRG unit based on user options in the QSO logging
  • Make the QRG input dynamic
  • Add ability to change unit by clicking on the button
  • Use localStorage to avoid ajax calls (to get the user options)
  • Port everything to contesting

Note about SimpleFLE

SimpelFLE is based on FLE by DF3CB which always uses MHz. To stay close to the original FLE syntax we use MHz here aswell.

@HB9HIL HB9HIL added the enhancement New feature or request label Nov 12, 2024
@HB9HIL HB9HIL added this to the 1.9 milestone Nov 12, 2024
@HB9HIL HB9HIL self-assigned this Nov 12, 2024
@HB9HIL HB9HIL marked this pull request as ready for review November 12, 2024 21:16
@HB9HIL HB9HIL linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works.
tested:

  • LiveQSO with CAT
  • LiveQSO without CAT
  • PostQSO
  • Contesting with CAT
  • Contesting without CAT
  • DXCluster / Spot-Click

Important:

since this one affects the core of logging, id appreciate another approve besides mine. Maybe i've overseen something

@int2001
Copy link
Contributor

int2001 commented Nov 13, 2024

Checked again. Now SAT is working too

@AndreasK79
Copy link
Contributor

Nice addition. Tested and clicked around. Logged a few QSOs. Seems ok to me.

@HB9HIL HB9HIL merged commit 24dbe2d into wavelog:dev Nov 17, 2024
@HB9HIL HB9HIL deleted the qrg_input branch November 17, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Frequency input
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy