Skip to content

Callbook refactor #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 27, 2024
Merged

Callbook refactor #1260

merged 19 commits into from
Nov 27, 2024

Conversation

AndreasK79
Copy link
Contributor

@AndreasK79 AndreasK79 commented Nov 25, 2024

Started on a refactor of how we do the callbook lookup.

The reason is simply that is should be much easier to add other callbooks, and maintain the code.

QRZCQ is tested working.
QRZ and HamQTH still works.

@AndreasK79 AndreasK79 marked this pull request as ready for review November 25, 2024 11:45
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great improvement. much cleaner code than before.
i tested a lot of calls and found no issue.

tbh: one cannot test every call-constellation, but i tried to test as much as possible.

i like

Copy link
Contributor

@phl0 phl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested around 30 callsigns which all parsed correctly. This looks fine to me. :)

@AndreasK79 AndreasK79 merged commit 7a7c81f into wavelog:dev Nov 27, 2024
@AndreasK79 AndreasK79 deleted the callbook_refactor branch July 30, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy