-
Notifications
You must be signed in to change notification settings - Fork 70
Callbook refactor #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callbook refactor #1260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great improvement. much cleaner code than before.
i tested a lot of calls and found no issue.
tbh: one cannot test every call-constellation, but i tried to test as much as possible.
i like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested around 30 callsigns which all parsed correctly. This looks fine to me. :)
Started on a refactor of how we do the callbook lookup.
The reason is simply that is should be much easier to add other callbooks, and maintain the code.
QRZCQ is tested working.
QRZ and HamQTH still works.