Fix time reset functions in post QSO #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HB9HIL
requested changes
Nov 26, 2024
|
Tnx feedback. The issues were fixed. Pls try agn. |
|
Was a (bad) copy and paste mistake. Sri. Merge time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1190 the reset functions were reafactored. This left the reset functions in post QSO with a bug that seconds were inserted upon reset of the timers. This leads to incorrect format for the input field and needs manual correction before saving the QSO:
So we need to add a differentiation here for live and post QSO and only add seconds if were are logging live.