Skip to content

Display a numeric keyboard for number input fields #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented Nov 26, 2024

This changes the numeric input fields so that on mobile / touch input platforms a simplified numeric keyboard is shown instead of a full blown text input one.

Before:

20241126_215629000_iOS

After:

20241126_215557000_iOS

@phl0 phl0 added the frontend things which are affecting Frontend/UI label Nov 26, 2024
@phl0 phl0 added this to the 1.9 milestone Nov 26, 2024
@phl0 phl0 self-assigned this Nov 26, 2024
@HB9HIL
Copy link
Contributor

HB9HIL commented Nov 26, 2024

This is on conflict with the new qrg input where you can enter 'khz', 'mhz' and so on to change the unit...

@HB9HIL
Copy link
Contributor

HB9HIL commented Nov 26, 2024

See also #1266

@phl0
Copy link
Contributor Author

phl0 commented Nov 27, 2024

This is on conflict with the new qrg input where you can enter 'khz', 'mhz' and so on to change the unit...

Rolled back the changes for the frequency input fields. Ok to merge?

@phl0 phl0 requested a review from HB9HIL November 27, 2024 08:22
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on those field (Az/Ele/Power).

@phl0
Copy link
Contributor Author

phl0 commented Nov 27, 2024

Idea for the two different approaches to frequency input fields: Make a (user) option to choose between old style (with nuneric keyboard options) and the advanced input options with auto format? @HB9HIL @int2001

@phl0 phl0 merged commit dbee96f into wavelog:dev Nov 27, 2024
@HB9HIL
Copy link
Contributor

HB9HIL commented Nov 27, 2024

Idea for the two different approaches to frequency input fields: Make a (user) option to choose between old style (with nuneric keyboard options) and the advanced input options with auto format? @HB9HIL @int2001

Well on Desktop you don't have the number bock anyway. I would rather make the input field type="number" when called on mobile/small screens. No need for another option.

Normal behaviour on Desktop
Num Block on Mobile

@phl0 phl0 deleted the numericInput branch November 27, 2024 15:34
@int2001
Copy link
Contributor

int2001 commented Nov 27, 2024

Both options (user option to deactivate the “intelligent parsing” of the qrg OR setting the field to number via JS when working mobile) means: Both branches must be maintained.

KISS (for user AND code) would be here: Use the button for the unit and put the field into num-type.

just my 2ct

@HB9HIL HB9HIL mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend things which are affecting Frontend/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy