Skip to content

[Installer] better debugging #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 4, 2024
Merged

[Installer] better debugging #1307

merged 12 commits into from
Dec 4, 2024

Conversation

HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented Dec 3, 2024

Added a lot of log_messages for better debugging in the installer and fixed the database version check which was accidentially a hard fence. Should be soft instead.

No other logic changes. Review with whitespace hidden.

Helps debugging in #1011 or #847

@HB9HIL HB9HIL added the installer Stuff which affects the wavelog installer label Dec 3, 2024
@HB9HIL HB9HIL added this to the 1.9 milestone Dec 3, 2024
@HB9HIL HB9HIL self-assigned this Dec 3, 2024
@HB9HIL HB9HIL changed the title [WIP][Installer] better debugging [Installer] better debugging Dec 3, 2024
@HB9HIL
Copy link
Contributor Author

HB9HIL commented Dec 3, 2024 •
edited
Loading

Tested on:

  • Debian 12
  • Linux Mint 21
  • Docker

There was an issue with the database version check. In some circumstance at mariadb the command $link->server_info returns not only the version, but also another version info (see stackoverflow link). So on Linux Mint 21 with the MariaDB version 10.6.18 which returns on server_info: 5.5.5-10.6.18-MariaDB-0ubuntu0.22.04.1

https://stackoverflow.com/questions/56601304/what-does-the-first-part-of-the-mariadb-version-string-mean

This breaks the Version Parser. Therefore I changed this to SELECT VERSION() which should work much better on MySQL and MariaDB.

@HB9HIL HB9HIL marked this pull request as ready for review December 3, 2024 11:24
int2001
int2001 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only tested for function and logs. didn't check code.

works well. installer_debug.log was created.
installation runs without any issues.

tested on docker

phl0
phl0 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@phl0 phl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works here.

@HB9HIL HB9HIL merged commit 8aab1f1 into wavelog:dev Dec 4, 2024
@HB9HIL HB9HIL deleted the installer_better_debug branch December 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@int2001 int2001 int2001 approved these changes

@phl0 phl0 phl0 approved these changes

Assignees

@HB9HIL HB9HIL

Labels
installer Stuff which affects the wavelog installer
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@HB9HIL @int2001 @phl0
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy