CleanUp primary_subdivisions and adif_modes before doing mig #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HB9HIL
reviewed
Dec 27, 2024
HB9HIL
approved these changes
Dec 27, 2024
|
Tested with no errors here. Set migration to 230, then upgraded. No errors in the log, and indexes were created. |
AndreasK79
approved these changes
Dec 28, 2024
phl0
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primary_subdivision-table has no PK.
this is no problemm but in combination with no downgrade here it could(!) produce dupes.
This one solves the problem, by:
Same problem at adif_modes. This PR cleans up the table and adds a proper unique_key