If there was an error at inserting QSO via API, return 400 #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will check later today |
phl0
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce:
insert a QSO with a different station_callsign than at station_profile. This one returns (in latest master/dev) a 201 (insert) but with "adif_error"-count > 0. And QSO wasn't inserted!!
With this PR a 400 would be returned and the messages-object will contain further information.
Part of resolving wavelog/WaveLogGate#26
Testing: Try to log a QSO with the API as described here: https://github.com/wavelog/wavelog/wiki/API#apiqso
Vary the station_callsign within the payload