Skip to content

Remove doubling WWFF-Ref to SIG-Fields #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

int2001
Copy link
Contributor

@int2001 int2001 commented Jan 1, 2025

Special-Treatment for WWFF-References has been introduced in 2022.
Reason was - according to the PR - "some third party tools need the WWFF-Information at SIG-Fields".

Since we try to be as near as possible to the ADIF-Standard, and WWFF itself uses its own fields, we should drop this treatment after 2 years.

Testing:

  • log a QSO with WWFF-Reference
  • Export it
  • You'll see WWFF-Reference at WWFF-Field as well as at SIG_ Fields

after applying patch:

  • log a QSO with WWFF-Reference
  • Export it
  • You'll see WWFF-Reference at WWFF-Field.
  • No more redundancy with SIG-Field

@int2001 int2001 self-assigned this Jan 1, 2025
@dg2ron
Copy link

dg2ron commented Jan 1, 2025

that's great.
This redundancy is completely unnecessary. There is the WWFF field and it should be used.
A nice side effect is that when importing, the WWFF information in the SIG field is also removed.
No more duplicate entries.

@int2001 int2001 merged commit de1ad0c into wavelog:dev Jan 1, 2025
@int2001 int2001 deleted the remove_double_sig branch February 5, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy