Skip to content

QSO Edit Modal fix #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2025
Merged

QSO Edit Modal fix #1548

merged 2 commits into from
Jan 24, 2025

Conversation

HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented Jan 24, 2025

Same issue as in #1237

Bad HTML ID's cause issue in the QSL Tab of the QSO edit modal.

image

Reproduce:

  • Open DXCC Award
  • Choose any QSO from the table
  • Open QSO Edit Modal
  • See failing tab control in QSL tabs

This PR fixes this issue by renaming the tab control ID's

thx to DL2COM for reporting this issue

@HB9HIL HB9HIL added the bug Something isn't working label Jan 24, 2025
@HB9HIL HB9HIL self-assigned this Jan 24, 2025
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find. tested --> Working

Fixes bug/warning where QSL_Message is empty
@HB9HIL HB9HIL merged commit 40d1e9a into wavelog:dev Jan 24, 2025
@HB9HIL HB9HIL deleted the qsl_edit_fix branch January 24, 2025 11:01
@HB9HIL HB9HIL added this to the 2.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy