-
Notifications
You must be signed in to change notification settings - Fork 70
[OQRS] Move from global options to user options #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AndreasK79
merged 28 commits into
wavelog:dev
from
AndreasK79:oqrs_move_to_user_options
Jul 23, 2025
Merged
[OQRS] Move from global options to user options #2152
AndreasK79
merged 28 commits into
wavelog:dev
from
AndreasK79:oqrs_move_to_user_options
Jul 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int2001
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good one.
tested:
- with instance-wide disabled OQRS: Works
- with enabled OQRS
- User-Edit
- Create OQRS
- Manage OQRS
Still a few UX-things open, but they'll come in another PR
HB9HIL
requested changes
Jul 18, 2025
Co-authored-by: Fabian Berg <fabian.berg@hb9hil.org>
Co-authored-by: Fabian Berg <fabian.berg@hb9hil.org>
Co-authored-by: Fabian Berg <fabian.berg@hb9hil.org>
Co-authored-by: Fabian Berg <fabian.berg@hb9hil.org>
HB9HIL
approved these changes
Jul 18, 2025
result was doubled (at data and at view agn result)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OQRS grouped needs slug, so the widget must provide that.