Skip to content

Default localhost for cronmanager in docker environments #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented Aug 3, 2025

There is a logical issue since the beginning of the cronmanager implementation in #306

It only affects installations which are using docker and keep the base_url at localhost and a different port then 80. It's quite simple (e.g. $config['base_url'] = 'http://localhost:8086/';)

localhost inside the container !== localhost in the host machine.

Reason is that we use port 8086 per default in our docker-compose.yml. This leads into the problem that the mastercron is correctly called inside the container with http://localhost[:80] (see Dockerfile) but the cron/run method gets http://localhost:8086 from the base_url config (via local_url() method). This obvisouly fails inside the container as in this little cute blue whale Wavelog is running on port 80, and not 8086.

There was a good solution around a year ago by @winnieXY in #795 but the people (and myself) forget about the config option. Therefore we use now http://localhost[:80] by default in docker environments which always works (because inside the container Wavelog always runs on localhost port 80). Thanks to @blhoward2 for poking me here. Even this is not a bug, it leads into a bad user experience when people running Wavelog in docker for the first time on their local machine and the cronmanager fails...

Solves

…/' in docker environments which will always work for the cron run method
@HB9HIL HB9HIL added this to the 2.0.8 milestone Aug 3, 2025
@HB9HIL HB9HIL self-assigned this Aug 3, 2025
@HB9HIL HB9HIL added the enhancement New feature or request label Aug 3, 2025
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find

@HB9HIL HB9HIL merged commit 570fcc0 into wavelog:dev Aug 4, 2025
@HB9HIL HB9HIL deleted the default_localhost branch August 4, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy