Create a helper to read in a optional local_url to bypass the need to… #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… access the application using the external url.
|
Okay, tested it on my local instance. Seems to work for me. Please also test and kindly review :-) |
HB9HIL
requested changes
Aug 23, 2024
Co-authored-by: HB9HIL <80885850+HB9HIL@users.noreply.github.com>
…rl config entry is missing.
HB9HIL
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Seems good to me. Tested with the cronmanager behind a proxy.
Grace Period of max. 24 hours before merge so @int2001, @phl0 or @AndreasK79 have a chance to see this change aswell
|
Please modify the Wiki article here: https://github.com/wavelog/wavelog/wiki/Recommended-Cron-Jobs-and-Cronmanager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I think i solved the issue with the cronmanager (at least for me).
This patch will create a config option "local_url" which can be used to provide an alternative url to access the cronmanager (e.g. "http://localhost/".
If this option is not set the base_url will be returned instead.