Just set the status of the cronjob if the job was run or was disabled. #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it and verified that with #795 applied (and wrong local_url) the failed state will be persistent, so the state gives indeed a good indicator if the cronjob is healthy or not. Caveat - if you enable a cronjob it will stick to "pending" till the first run. Currently it will state "healthy" as soon as a time for the next execution is calculated. However I think that this is acceptable, as the cronjob is indeed pending and we do not know (yet) if it is healthy or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small patch will just set the "healthy" flag if the cron was executed or was disabled/enabled, so that a failed flag persists.
This a attempt to close #794