Skip to content

Refactor SAT stuff #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Dec 2, 2024
Merged

Refactor SAT stuff #996

merged 33 commits into from
Dec 2, 2024

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented Sep 24, 2024 •
edited
Loading

Cleaning up a few things:

  • Make naming of satellites consistent (use LoTW names where assigned)
  • Rename SAT_NAME in log table where non-LoTW names were stored
  • Add column to satellite table showing if LoTW accepted or not
  • Ignore non-LoTW accepted satellites in LoTW upload

@phl0 phl0 added the enhancement New feature or request label Sep 24, 2024
@phl0 phl0 added this to the 1.8.6 milestone Sep 24, 2024
@phl0 phl0 requested a review from int2001 September 24, 2024 14:06
@phl0 phl0 self-assigned this Sep 24, 2024
@phl0 phl0 modified the milestones: 1.8.6, 1.8.7 Oct 7, 2024
@phl0 phl0 modified the milestones: 1.8.7, 1.8.9 Nov 11, 2024
@phl0 phl0 added the frontend things which are affecting Frontend/UI label Nov 11, 2024
@phl0 phl0 changed the title [WIP]: Refactor SAT stuff Refactor SAT stuff Dec 1, 2024
@phl0 phl0 marked this pull request as ready for review December 1, 2024 23:39
@phl0
Copy link
Contributor Author

phl0 commented Dec 1, 2024

This is now brushed up and imho ready to test. Would like at least @int2001 to give it a go :)

@phl0 phl0 removed this from the 1.8.9 milestone Dec 1, 2024
@phl0 phl0 added this to the 1.9 milestone Dec 1, 2024
int2001
int2001 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested nearly every view. Well done. Huge effort for that. but it's worth it.

@phl0 phl0 merged commit 73fbe02 into wavelog:dev Dec 2, 2024
@phl0 phl0 deleted the refactorSat branch December 2, 2024 18:15
@phl0 phl0 mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@int2001 int2001 int2001 approved these changes

@AndreasK79 AndreasK79 AndreasK79 approved these changes

Assignees

@phl0 phl0

Labels
enhancement New feature or request frontend things which are affecting Frontend/UI
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@phl0 @int2001 @AndreasK79
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy