Skip to content

Fix | Dependencies | Symfony packages upgraded to correct dump() functionality #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

nickdenardis
Copy link
Member

Reason for change

Updates our dependencies to correct an upstream issue introduced and then reverted in the var-dumper package.

Discussions:

Issue

Using dump() anywhere before the returned view() would prevent the view from being rendered.

Before and after screenshots below with the following code:

public function index(Request $request): View
{
    dump('here');
    return view('childpage', merge($request->data));
}

Reminders

  • Update package version number
  • Frontend accessibility check
  • Styleguide example in place
  • New functionality covered by tests
  • Screenshots of multiple screen sizes

Demo

Before After
Screenshot 2025-07-18 at 1 53 47 PM Screenshot 2025-07-18 at 1 54 08 PM

@nickdenardis nickdenardis self-assigned this Jul 18, 2025
@nickdenardis nickdenardis requested a review from a team as a code owner July 18, 2025 18:05
@nickdenardis nickdenardis added bug dependencies Pull requests that update a dependency file labels Jul 18, 2025
@nickdenardis nickdenardis merged commit ddc6e86 into master Jul 18, 2025
1 check passed
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling b93ccaf on hotfix/8.14.5
into ebf0235 on master.

@nickdenardis nickdenardis deleted the hotfix/8.14.5 branch July 18, 2025 18:08
@breakdancingcat
Copy link
Member

Yay!! Thank you!

Copy link
Member

@chrispelzer chrispelzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Contributor

@KyleApsey KyleApsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy