Fix multiline comments highlighting in c++ #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafalk342 Thanks for your help! #21 |
anlambert
reviewed
Jan 23, 2018
| var children = element.childNodes; | ||
| for(var child in children){ | ||
| if(children.hasOwnProperty(child)) { | ||
| if(children[child].className === "hljs-comment"){ |
There was a problem hiding this comment.
Testing against "hljs-string" also fixes the highlighting of multi-line strings
|
For your information, there is a similar issue regarding the highlighting of multi-line strings (for instance, Python ones). See comment in the PR diff for the fix. |
swhmirror
pushed a commit
to SoftwareHeritage/swh-web
that referenced
this pull request
Jan 23, 2018
|
Hi everyone I investigated this issue #21 and made a common solution. Please, try it on the separate branch: |
|
Hi @wcoder, I confirm this fixes the encountered issues. Cheers! |
|
Hello @wcoder, |
|
Thank you for feedbacks and check. Released new version 2.2 with this fix. |
swhmirror
pushed a commit
to SoftwareHeritage/swh-web
that referenced
this pull request
Feb 23, 2018
This new release fixes multi-line strings and comments highlighting bugs (see wcoder/highlightjs-line-numbers.js#22 and wcoder/highlightjs-line-numbers.js#30).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've corrected handling multiline comments in c++.
Every tag with a multiline comment is changed into a multiple tags with only one line.