refactor: simplify plugin environment handling #5616
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the plugin environment handling system by removing the RSBUILD_ALL_ENVIRONMENT_SYMBOL constant and simplifying the logic for matching plugins to environments. The key changes include making environment specifications optional and changing the matching logic to be more explicit.
- Removed
RSBUILD_ALL_ENVIRONMENT_SYMBOLconstant and related logic - Modified
PluginMeta.environmentto be optional, with undefined meaning "all environments" - Simplified environment matching logic with a new
isEnvironmentMatchfunction - Refactored plugin removal tracking to use Sets instead of arrays
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/types/plugin.ts | Made environment property optional in PluginMeta type with documentation |
| packages/core/src/pluginManager.ts | Replaced symbol-based logic with optional environment handling and simplified matching |
| packages/core/src/initPlugins.ts | Updated function calls to use new environment matching function |
| packages/core/src/hooks.ts | Updated function calls to use new environment matching function |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Summary
Improve code readability and simplify plugin environment handling by removing the
RSBUILD_ALL_ENVIRONMENT_SYMBOLvariable.Checklist