feat!: minimum supported webpack version is 5.0.0 #1389
Conversation
| // Todo remove when we drop webpack@4 support | ||
| if (typeof outputFileSystemFromOptions.join !== "function") { | ||
| throw new Error( | ||
| "Invalid options: options.outputFileSystem.join() method is expected" | ||
| ); | ||
| } | ||
|
|
||
| // Todo remove when we drop webpack@4 support | ||
| // @ts-ignore | ||
| if (typeof outputFileSystemFromOptions.mkdirp !== "function") { | ||
| throw new Error( | ||
| "Invalid options: options.outputFileSystem.mkdirp() method is expected" | ||
| ); | ||
| } |
There was a problem hiding this comment.
@alexander-akait Do we need this with webpack v5?
There was a problem hiding this comment.
Otherwise, I'll remove test cases for this as well, which are currently failing.
There was a problem hiding this comment.
If this tests for webpack - Yes
There was a problem hiding this comment.
We have a lot of integration tests, so we will catch if it will have problems
Codecov ReportBase: 97.48% // Head: 97.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1389 +/- ##
==========================================
- Coverage 97.48% 97.34% -0.14%
==========================================
Files 9 9
Lines 398 377 -21
Branches 123 112 -11
==========================================
- Hits 388 367 -21
Misses 9 9
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR contains a:
Motivation / Use-Case
Drop webpack v4
Breaking Changes
minimum supported webpack version is 5.0.0
Additional Info