Skip to content

fix: should update initial chunks correctly with filename #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Jul 18, 2025

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fix #1133

Initial css chunk cannot update if user specify filename or chunkFilename. Because MiniCssExtractPlugin has GetChunkFilenameRuntimeModule and force the allChunks parameter to be false, that will cause that runtime cannot get correct url for updated initial css chunk.

This change aligns behavior of webpack's native css support.

Breaking Changes

Additional Info

@JSerFeng
Copy link
Contributor Author

How can I add test for this case, seems HMR.test is not what I'm looking for

@JSerFeng JSerFeng changed the title fix: should contains GetFilenameRuntime for initial chunks fix: should update initial chunks correctly with filename Jul 18, 2025
@alexander-akait
Copy link
Member

@JSerFeng Sorry for delay, can you provide a steps to reproduce? I tried your repo and everything works...

@alexander-akait
Copy link
Member

I see, yeah, it is a bug, let's merge, I will fix tests, thanks

@alexander-akait alexander-akait merged commit dab023f into webpack-contrib:master Jul 31, 2025
3 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial style cannot update
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy