fix: should update initial chunks correctly with filename #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can I add test for this case, seems HMR.test is not what I'm looking for |
|
@JSerFeng Sorry for delay, can you provide a steps to reproduce? I tried your repo and everything works... |
|
I see, yeah, it is a bug, let's merge, I will fix tests, thanks |
dab023f
into
webpack-contrib:master
3 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fix #1133
Initial css chunk cannot update if user specify
filenameorchunkFilename. BecauseMiniCssExtractPluginhasGetChunkFilenameRuntimeModuleand force theallChunksparameter to befalse, that will cause that runtime cannot get correct url for updated initial css chunk.This change aligns behavior of webpack's native css support.
Breaking Changes
Additional Info