Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Fix sharing bugs #5087

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[YiR] Fix sharing bugs #5087

merged 2 commits into from
Nov 21, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T376300

Notes

This PR fixes some issues with the sharing view:

  1. Facebook and Instagram sharing is fixed. We're only sharing the image - it seems like having both text and image caused issues.
  2. Fixed cropping issues on the last donate slide
  3. Fixed markdown display in share view subtitle.

Note: I have noticed the subtitle truncates. I'm not sure if this was introduced by this PR or not, but Product has said this is ok for V1.

Test Steps

  1. Check to see if you can share to Facebook and Instagram (can lean on QA for this).
  2. Check that last donate slide sharing looks good (gradient crop and learn more url).

- use attributed string instead of displaying markup
- fix layout issue when there's an image overlay
@tonisevener tonisevener changed the title Fix sharing 2 [YiR] Fix sharing bugs Nov 21, 2024
@l-olson1214 l-olson1214 self-requested a review November 21, 2024 03:44
@mazevedofs mazevedofs merged commit fbc5509 into release/7.6.2 Nov 21, 2024
7 checks passed
@mazevedofs mazevedofs deleted the fix-sharing-2 branch November 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy