T377899 edit spanish #5088
Closed
T377899 edit spanish #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump app version to 7.6.3
When hiding find in page, it's also necessary to set the fin in page view as nil. This forces the view to stop being first reponder as it updates canBecomeFirstResponder to false.
Remove unused props
[YiR] Prompt user to log in after survey
Fix Article Web View Link Bug
mazevedofs
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Hi Grey! It seems like you branched off main, and your PR is carrying commits from main that we're not adding to this release. Could you cherry-pick your desired commits and add them to a branch that stemmed from release/7.6.2? Let me know if you need help with cherry-picking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T377899
Notes
Test Steps
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-11-20.at.22.41.32.mp4